Closed mmsqe closed 2 years ago
pacrob
commented
2 years ago We had talked about whether to backport this or not. I think we decided not to because it was determined to be breaking how things had worked for a while, even if those things weren't working "correctly" in some cases. Open for discussion, though.
v7 is coming soon and will have all the updates.
mmsqe
commented
2 years ago We had talked about whether to backport this or not. I think we decided not to because it was determined to be breaking how things had worked for a while, even if those things weren't working "correctly" in some cases. Open for discussion, though.
v7is coming soon and will have all the updates.
Got it thanks.
backport https://github.com/ethereum/eth-account/pull/175 to v0.5.x
fix get_dependencies() to properly parse array types
rewrote encode_data() to properly handle array types - single and nested, fixed and dynamic length
removed requirement that nested arrays have only a single dimension at a particular depth
rewrote get_array_dimensions() to invert array dimensions as this is how Solidty reads them.
Co-authored-by: Wai Keen Woon doubleukay@doubleukay.com Co-authored-by: pacrob paul@pacrob.com Co-authored-by: Felipe Selmo fselmo2@gmail.com
How was it fixed?
Summary of approach.
To-Do
[ ] Clean up commit history
[ ] Add entry to the release notes
Cute Animal Picture
![put a cute animal picture link inside the parentheses]()