search

ethereum / eth-account

Account abstraction library for web3.py
http://eth-account.readthedocs.io/
MIT License
260 stars 156 forks source link

Implicit dependency on cytoolz (breaks PyPy) #215

Closed oberstet closed 6 months ago

oberstet commented 1 year ago

The library depends on toolz.dicttoolz.dissoc

https://github.com/ethereum/eth-account/blob/c5552a56b349e4c205089f50ddf54e942d4d9bc9/eth_account/account.py#L752

even though this requirement is not stated in the package setup

https://github.com/ethereum/eth-account/blob/c5552a56b349e4c205089f50ddf54e942d4d9bc9/setup.py#L67

This could be replaced with

from copy import deepcopy
sanitized_transaction = deepcopy(transaction_dict)
sanitized_transaction.pop('from', None)

without introducing a dependency on cytoolz and allowing this library to be used on PyPy.

kclowes commented 6 months ago

closed via #251