Add ability to call encode_typed_data with a single dict argument - Githubissues

ethereum / eth-account

Account abstraction library for web3.py

http://eth-account.readthedocs.io/

MIT License

269 stars 156 forks source link

Add ability to call encode_typed_data with a single dict argument #238

Closed pacrob closed 1 year ago

pacrob commented 1 year ago

What was wrong?

The former encode_structured_data, Mask, and even the original EIP expect the message to be a single json object/python dict.

How was it fixed?

Added the different arg option, plus docs and an example.
Added tests to make sure calling encode_typed_data with 3 args provides the same result as with 1 arg
Found a bug in handling empty and missing arrays in message, fixed and added tests

Todo:

[x] Clean up commit history
[x] Add or update documentation related to these changes
[x] Add entry to the release notes

Cute Animal Picture

pacrob commented 1 year ago

I strongly feel like we should combine these single json file test cases

Done! And I learned that pytest will easily parametrize a dict and use the keys for the test id.