sign_typed_data has been implemented with the intention of producing similar results as metamask and ethers-js, but the current test cases only compare with a static value (hash or sig)
How was it fixed?
Built on the existing javascript mnemonic testing, verify messages encode to the same sig where expected. Test cases explain why where they don't match.
Fixed a bug in encoding where the order of encoding the domain data was determined by the data (a json object, which is unordered) instead of the standard domain types (an array, which is ordered).
Todo:
[ ] Clean up commit history
[x] Add or update documentation related to these changes
What was wrong?
sign_typed_data
has been implemented with the intention of producing similar results as metamask and ethers-js, but the current test cases only compare with a static value (hash or sig)How was it fixed?
Todo:
[ ] Clean up commit history
[x] Add or update documentation related to these changes
[x] Add entry to the release notes
Cute Animal Picture