Closed pacrob closed 9 months ago
Are we ready for a major release without backporting? Not having upper pins on our libraries that are dependent on eth-account
may complicate things. We decided to hold off on the hexbytes
pin for a similar reason, right? Just checking.
Are we ready for a major release without backporting?
Yes, we can release all we want, major or minor, as long as we keep the hexbytes<0.4.0
. Once web3 v7 is out (which will include hexbytes>=1.0.0
), we will go through all the other libs that depend on hexbytes, change them to >=1.0.0
, and release major.
If we don't have upper pins for eth-account on depending libraries and they haven't switched to snake case, then that would break, no?
On Thu, Nov 30, 2023, 14:38 Paul Robinson @.***> wrote:
Are we ready for a major release without backporting?
Yes, we can release all we want, major or minor, as long as we keep the hexbytes<0.4.0. Once web3 v7 is out (which will include hexbytes>=1.0.0), we will go through all the other libs that depend on hexbytes, change them to >=1.0.0, and release major.
— Reply to this email directly, view it on GitHub https://github.com/ethereum/eth-account/pull/244#issuecomment-1834671293, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26QGGOGMA752UTF7PMVS3YHEDF5AVCNFSM6AAAAABAB4ZR26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGY3TCMRZGM . You are receiving this because your review was requested.Message ID: @.***>
If we don't have upper pins for eth-account on depending libraries and they haven't switched to snake case, then that would break, no?
Yes, they would. That's the danger of not having upper pins.
What was wrong?
Several methods that were originally camelCase had direct snake_case replacements. They were deprecated ~5 years ago.
How was it fixed?
Removed the deprecated camelCase version.
Does not touch the
signHash
->sign_message
deprecation, as there's some discussion there sort out.Todo:
[x] Clean up commit history
[x] Add or update documentation related to these changes
[x] Add entry to the release notes
Cute Animal Picture