ethereum / eth-account

Account abstraction library for web3.py
http://eth-account.readthedocs.io/
MIT License
258 stars 155 forks source link

Remove signHash in favor of unsafe_sign_hash #260

Closed kclowes closed 5 months ago

kclowes commented 5 months ago

What was wrong?

It's not safe to sign random hashes, but occasionally developers want to do so. We were undecided about what to do with the method, but decided to add a new method called unsafe_sign_hash and finally remove signHash

Closes #85

How was it fixed?

Removed signHash, moved functionality to unsafe_sign_hash.

LMK if you think we should add more/different docs

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Uxio0 commented 5 months ago

Sounds like a really good solution, thanks @kclowes