search

ethereum / eth-account

Account abstraction library for web3.py
http://eth-account.readthedocs.io/
MIT License
258 stars 155 forks source link

Deprecate messageHash #264

Closed kclowes closed 5 months ago

kclowes commented 5 months ago

What was wrong?

messageHash is a remnant of camelCasing.

Related to Issue #176

How was it fixed?

Added a DeprecationWarning when users try to access messageHash, added a message_hash attribute to SignedMessage so folks can upgrade.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

fselmo commented 5 months ago

We should add SignedTransaction.rawTransaction to this or were you thinking to do that in a separate PR?

kclowes commented 5 months ago

I was going to do a separate PR, but could add here. Doesn't matter much to me