Closed fselmo closed 5 months ago
bugfix
and removal
newsfragments to explain the patch as a removal of pydantic
dependency for 0.11.x
?
bugfix and removal newsfragments to explain the patch as a removal of pydantic dependency for 0.11.x?
I think bugfix might suffice, but I'll leave it up to your good judgement :)
What was wrong?
pydantic
as a dependency in0.11.x
was not necessary and it was not appropriate for a patch release (see issue ethereum/eth-account#270). This is simple enough to remove for0.11.x
and leave it for0.12.x
.Related to Issue #270
How was it fixed?
pydantic
as a dependency. This is simple enough to handle by defining__init__()
methods that validate inputs to thedata
coming into each of the blob class objects.Note: By removing
pydantic
, we don't validate the input'stype
in the data models but this should be consistent with the rest of the library up to0.11.0
. That's one additional benefit we get from thepydantic
implementation in0.12.x
.Todo:
Cute Animal Picture