Closed kclowes closed 2 months ago
Just to note, I'm not able to reproduce the DeprecationWarning using the enum on current main. How did you get it to show?
In your terminal:
$ export PYTHONWARNINGS=always
and you should see it
and you should see it
Still doesn't show for me, but no reason to hold this up. It's still an improvement over existing!
What was wrong?
We made the language that gets passed into the HD Accounts an
Enum
, and deprecated passing the string representation in. However, the DeprecationWarning was getting raised even though an Enum got passed.How was it fixed?
Removed extraneous DeprecationWarnings, and changed the return value of
detect_language
because I didn't see it documented anywhere, and therefore I am assuming it was meant to be a private method. Also added a newlist_languages_enum
method. Could stand to come up with a better name for that method, if you have any ideas. Additionally, added a few tests.Todo:
Cute Animal Picture