search

ethereum / eth-hash

The Ethereum hashing function, keccak256, sometimes (erroneously) called sha256 or sha3
MIT License
104 stars 64 forks source link

Include tests in PyPI tarball #20

Closed dotlambda closed 6 years ago

dotlambda commented 6 years ago

What was wrong?

The tests/ directory is missing from the tarball released on PyPI. Having the tests is useful for downstream distributions to test if the package works correctly with their build recipe. Also, it provides a way to test if the dependencies as they are packaged by the distribution are compatible.

How was it fixed?

Add MANIFEST.in.

pipermerriam commented 6 years ago

It looks like this is not uncommon for other major projects (though I haven't seen it before)

https://github.com/django/django/blob/master/MANIFEST.in#L15

I'm :+1: if you'd like to open a PR adding a similar line to our MANIFEST.in file.

dotlambda commented 6 years ago

I've changed it to use graft instead of recursive-include.