search

ethereum / eth-hash

The Ethereum hashing function, keccak256, sometimes (erroneously) called sha256 or sha3
MIT License
104 stars 64 forks source link

eth-hash dependency on eth-utils causes a circular dependency. #32

Closed ilyalesokhin-starkware closed 3 years ago

ilyalesokhin-starkware commented 3 years ago

eth-hash dependency on eth-utils causes a circular dependency. As a result, eth-hash cannot be used with Bazel.

When trying to install eth_hash bazel prints the following error message: @reqs//pypiweb3:pypiweb3 .-> @reqs//pypieth_utils:pypi__eth_utils | @reqs//pypieth_hash:pypieth_hash `-- @reqs//pypi__eth_utils:pypieth_utils This cycle occurred because of a configuration option

skimming over the code it does not seem like eth-utils is a real dependency. Is it possible to remove said dependency?

carver commented 3 years ago

Hm, interesting. Thanks for the report, and for digging into it!

Yeah, removing it seems like the right choice. Are you interested submitting the PR?

ilyalesokhin-starkware commented 3 years ago

I've opened a PR. Can you comment if anything else needs to be done? eth-utils is mentioned in some documentation but I didn't find any actual usage.

carver commented 3 years ago

Just found that this was accidentally introduced in #29 .

The fix is released as v0.3.2.