search

ethereum / eth-keyfile

Tools for handling the encrypted keyfile format used to store private keys.
MIT License
78 stars 49 forks source link

Expecting keyfile to have an 'address' element #2

Closed carver closed 6 years ago

carver commented 6 years ago

web3.js v1 claims to produce an 'address' element when encrypting a json keyfile. (The public account address, as you'd expect)

Can that be added in ethereum-keyfile?

Everything else looks like a match (except that web3.js defaults to scrypt, but I don't see why that needs to be the same).

pipermerriam commented 6 years ago

Yes, it was left out originally because I needed the ECDSA operations to convert the private key to the address, and I hadn't done those yet. Should be a very simple addition.

pipermerriam commented 6 years ago

Any chance you're willing to add it?

carver commented 6 years ago

Sure, I can set it up tomorrow.

Edit: and by tomorrow, I mean Monday

stefanmendoza commented 6 years ago

@carver was looking through the issues to find something to work on and I think this one can be closed with #4. 👍