search

ethereum / eth-keys

A common API for Ethereum key operations.
MIT License
159 stars 64 forks source link

Fix deprecation warnings #52

Closed cburgdorf closed 5 years ago

cburgdorf commented 5 years ago

What was wrong?

The following deprecation warnings came up when using the library (e.g. when Trinity boots)

/home/cburgdorf/Documents/hacking/ef/trinity/venv/lib/python3.7/site-packages/eth_keys/datatypes.py:107: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  class BaseKey(ByteString, collections.Hashable):

How was it fixed?

Changed imports from collections.* to collections.abc.* Also fixes a wrong type hint that came up due to a newer eth_utils version.

Cute Animal Picture

Cute animal picture

cburgdorf commented 5 years ago

@pipermerriam looks like I can't merge in this repo.