search

ethereum / eth-keys

A common API for Ethereum key operations.
MIT License
159 stars 64 forks source link

Compressed #56

Closed jannikluhn closed 5 years ago

jannikluhn commented 5 years ago

What was wrong?

Missing support for compressed public keys (#55).

How was it fixed?

I'm not an expert in cryptography, so please review carefully, especially the native backend code.

Cute Animal Picture

Cute animal picture

jannikluhn commented 5 years ago

Added the suggested hypothesis test, improved the validation error message, and updated the readme.

Also, when looking at the readme I realized that the key compression API is duplicated: Once in PublicKey (where one would naturally look for it) and once in KeyAPI (where it doesn't make too much sense IMO). I therefore removed it from KeyAPI and udpated the tests accordingly.

carver commented 5 years ago

Anything else to add today @pipermerriam ? If not, I'll merge by EOD.

jannikluhn commented 5 years ago

I don't have write access here, can someone merge please?

carver commented 5 years ago

Would you like a release after #58 is merged?

jannikluhn commented 5 years ago

Thanks!

Would you like a release after #58 is merged?

Yep, that would be nice.