search

ethereum / eth-keys

A common API for Ethereum key operations.
MIT License
159 stars 64 forks source link

Remove deprecated import #65

Closed cburgdorf closed 4 years ago

cburgdorf commented 4 years ago

What was wrong?

We are importing from a deprecated library causing warnings in downstream projects such as Trinity.

/home/cburgdorf/Documents/hacking/ef/trinity/venv/lib/python3.7/site-packages/eth_keys/datatypes.py:28: DeprecationWarning: The eth_utils.typing module will be deprecated in favor of eth-typing in the next major version bump.
  from eth_utils.typing import (

How was it fixed?

Add eth-typing dependency and use ChecksumAddress from there.

Cute Animal Picture

Cute animal picture

cburgdorf commented 4 years ago

@njgheorghita ping for review

cburgdorf commented 4 years ago

Oh, wait a minute, this is causing a sea of failed tests...

cburgdorf commented 4 years ago

Alright, it's ready for review now.

cburgdorf commented 4 years ago

@pipermerriam I don't have merge rights in this repo

cburgdorf commented 4 years ago

@pipermerriam Could you merge this for me (or grant me merge rights)