search

ethereum / eth-keys

A common API for Ethereum key operations.
MIT License
161 stars 64 forks source link

Use ValidationError from eth_utils #68

Closed gsalgado closed 4 years ago

gsalgado commented 4 years ago

Having a ValidationError defined both here and there makes no sense and forces callsites to catch them both in some situations.

carver commented 4 years ago

This causes breakages in libraries (eth_keys.exceptions.ValidationError was a publicly used API). I had released this change as a patch release.

I missed that it was a breaking change when scanning the included PRs since the last release. What would have helped me when doing the release is if this PR either:

1) highlighted this as a breaking change, or 2) patched through eth_utils.ValidationError as the new publicly available eth_keys.exceptions.ValidationError (which I think would have been backwards compatible)

carver commented 4 years ago

I'm contemplating doing another patch release v0.3.3 that takes route 2 above