Expose factories for 3rd party use - Githubissues

ethereum / eth-keys

A common API for Ethereum key operations.

MIT License

162 stars 64 forks source link

Expose factories for 3rd party use #69

Open pipermerriam opened 4 years ago

pipermerriam commented 4 years ago

What was wrong?

It is nice to be able to easily generate dummy data for tests.

https://github.com/ethereum/trinity/blob/545a1d59eb78195bef00a83f5d40cbfa267f31cf/p2p/tools/factories/keys.py

The above uses factory-boy to create factories for generating PublicKey and PrivateKey instances for testing.

How can it be fixed?

copy the factories from above into eth_keys.tools.factories
document their existence and usage in the docs.
add a [factories] into the extras_require that includes the factory-boy dependency.

JC-swEng commented 2 years ago

Is this issue still open?