search

ethereum / eth-keys

A common API for Ethereum key operations.
MIT License
159 stars 64 forks source link

py.typed marker not included in the package #89

Closed mdantonio closed 2 years ago

mdantonio commented 2 years ago

What was wrong?

The package has type hints and has a py.typed marker, but it is not included when the package is installed. As a consequence mypy ignore the package with error:

Skipping analyzing "eth_keys": module is installed, but missing library stubs or py.typed marker

How can it be fixed?

py.typed is included in package_data but I think that the package name is wrong:

This:

    package_data={'eth-keys': ['py.typed']},

should be:

    package_data={'eth_keys': ['py.typed']},

i.e. eth-keys -> eth_keys

fselmo commented 2 years ago

Thanks for reporting @mdantonio 👌. Seems simple enough. We should be able to get to this soon but if you'd like to submit a PR I think that might move things along quicker as well.

mdantonio commented 2 years ago

Sure! It is done

kclowes commented 2 years ago

Closed with #90