search

ethereum / eth-typing

Python types for type hinting commonly used ethereum types
MIT License
31 stars 35 forks source link

``v4`` Add ``ABIElementInfo`` to ``__init__.py`` #87

Closed reedsa closed 4 months ago

reedsa commented 4 months ago

What was wrong?

ABIElementInfo is missing from __init__.py. It should be included as part of __all__.

Docstrings in deprecated functions are missing deprecation warnings. Deprecation messages were not entirely accurate and should list all relevant alternate types as part of the message.

How was it fixed?

Add ABIElementInfo to __init__.py.

Update deprecation messages to include all relevant new types, add deprecation messages to docstrings.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

reedsa commented 4 months ago

I'm unable to replicate the issue, I am able to see the deprecation warning after I installed with pip install git+https://github.com/reedsa/eth-typing@docstrings-with-deprecation-notice.

reedsa commented 4 months ago

Circleci is giving me beef, connection drops from github for some reason. Going to keep kicking that job, will merge when it's green!