Fix curried type annotations

ethereum / eth-utils

Utility functions for working with ethereum related codebases.

https://eth-utils.readthedocs.io/en/latest/

MIT License

312 stars 150 forks source link

Fix curried type annotations #200

Closed carver closed 4 years ago

carver commented 4 years ago

What was wrong?

Fixes #156

How was it fixed?

Add @overload definitions in the curried module.

To-Do

[x] Clean up commit history
[x] Add entry to the release notes

Cute Animal Picture

put a cute animal picture link inside the parentheses

carver commented 4 years ago

I checked this against py-evm, which now passes its mypy check.

carver commented 4 years ago

I sort of expected to see new tests in https://github.com/ethereum/eth-utils/tree/c5595dda76e3a0150a36a2b4cdfb4594e3631444/tests/type-checks but I don't have any specific tests to suggest...

Yeah, the main issue seemed to be checking that all the methods are importable, so I added that check. (and confirmed that it fails before the change, although I did that check with a more recent mypy)