Upgrade template - Githubissues

ethereum / eth-utils

Utility functions for working with ethereum related codebases.

https://eth-utils.readthedocs.io/en/latest/

MIT License

312 stars 148 forks source link

Upgrade template #252

Closed reedsa closed 11 months ago

reedsa commented 11 months ago

What was wrong?

Releasing is hard

How was it fixed?

Fixes the release script by merging the template updates.

Updates include:

Release script has been updated to check the git remote properly
better words in docs, comments

Todo:

[x] Clean up commit history
[x] Add or update documentation related to these changes
[x] Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

reedsa commented 11 months ago

I noticed we dont have linting configured for Python 3.7 but still build the wheel. Is that intentionally skipped?

Also see the versions for flake8, etc are outdated but that could be another issue.

pacrob commented 11 months ago

I noticed we dont have linting configured for Python 3.7 but still build the wheel. Is that intentionally skipped?

Yes, py37 linting was borked and deemed not worth figuring out why, since all py37 testing will be dropped sooner than later.

Also see the versions for flake8, etc are outdated but that could be another issue.

You can try bumping the versions and see what needs updating. If it's just a few files, I'd say go ahead and add it here. If it makes major changes, a new PR would be preferred.

pacrob commented 11 months ago

Looks great! Just moving main back to master in documentation. I also found a reference to just doc in docs/overview.rst. You could delete the Join that chat at + gitter link there too - gitter is long dropped in favor of discord.