ethereum / eth-utils

Utility functions for working with ethereum related codebases.
https://eth-utils.readthedocs.io/en/latest/
MIT License
312 stars 148 forks source link

correct format of pyproject.toml bools and add test for __version__ #263

Closed pacrob closed 8 months ago

pacrob commented 8 months ago

What was wrong?

Some bools in pyproject.toml the wrong type - changed "True" to true. Added a test to make sure the __version__ attribute is available for the lib.

Todo:

Cute Animal Picture

image

pacrob commented 8 months ago

Were there any changes to the code needed based on the updated pyproject settings? Curious if imports are sorted for example. lgtm overall!

pre-commit did not make any changes after changing "True" to true. Testing with the toml lib, the "True" value is loaded as a string instead of a bool. So either the linting tools know to evaluate a string true as a bool or it just evaluates a non-empty string as true. No false values to check with.