Update return values of eth_getTransactionByHash

ethereum / eth-wiki

Ethereum Wiki

https://eth.wiki

48 stars 34 forks source link

Update return values of eth_getTransactionByHash #1

Closed hm0429 closed 6 years ago

hm0429 commented 6 years ago

Transaction includes v, r, s from geth v1.5.0: https://github.com/ethereum/go-ethereum/commit/b0d9f7372a04fa8f0ffc391f0997e2e062d465ef#diff-607ee6300c766df112070d851a1661c9R691

Where RPCTransaction is defined: https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/api.go#L860

virgil commented 6 years ago

Got your email. In short, if you want your name on your contributions, use the Pull Request. Otherwise, just use the ethereum.wiki interface and have at it.

hm0429 commented 6 years ago

Thanks for the clarification!