search

ethereum / eth-wiki

Ethereum Wiki
https://eth.wiki
48 stars 34 forks source link

'Subtleties' page wrongly states Ether is sent with reverting transaction #11

Closed ChrisChinchilla closed 4 years ago

ChrisChinchilla commented 5 years ago

Transferred from https://github.com/ethereum/wiki/issues/665

Approval from @virgil and @chrischinchilla

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 35.0 DAI (35.0 USD @ $1.0/DAI) attached to it as part of the ConsenSys Grants fund.

acolytec3 commented 5 years ago

This one looks like it's already fixed. Is this still an open bounty?

ChrisChinchilla commented 5 years ago

@acolytec3 The issue was created in June and the page was last updated in 2018, so I guess it's not fixed?

PS. Are you at the ETHBerlin hackathon?

acolytec3 commented 5 years ago

It's still showing the old copy in the ethereum/wiki repo but it's been corrected in the ethresearch repo. Which one are you looking to have fixed? If the ethereum wiki, despite what the contribution guidelines state, I don't appear to be able to update it.

And no, I'm not at Ethberlin. Does that make me ineligible to participate in these?

ChrisChinchilla commented 5 years ago

@acolytec3 We kind of wanted people to be at ETHBerlin, but can't really stop anyone. But yes, we're aiming to fix the issues from the original wiki and slowly migrate into the new one. Odd that it's already fixed there, but good that it is. So I guess this issue/bounty is unfortunately invalid :(

acolytec3 commented 5 years ago

Ah, sorry. I stopped work on it and won't hit any more of them.

On Fri, Aug 23, 2019, 4:17 PM Chris Chinchilla notifications@github.com wrote:

@acolytec3 https://github.com/acolytec3 We kind of wanted people to be at ETHBerlin, but can't really stop anyone. But yes, we're aiming to fix the issues from the original wiki and slowly migrate into the new one. Odd that it's already fixed there, but good that it is. So I guess this issue/bounty is unfortunately invalid :(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ethresearch/eth-wiki/issues/11?email_source=notifications&email_token=AEENFXA7UDN5M3T23SZKYCLQGBAURA5CNFSM4IL4DCR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BHDJY#issuecomment-524448167, or mute the thread https://github.com/notifications/unsubscribe-auth/AEENFXHOUM4C24IHFDK5M5TQGBAURANCNFSM4IL4DCRQ .

On Fri, Aug 23, 2019, 4:17 PM Chris Chinchilla notifications@github.com wrote:

@acolytec3 https://github.com/acolytec3 We kind of wanted people to be at ETHBerlin, but can't really stop anyone. But yes, we're aiming to fix the issues from the original wiki and slowly migrate into the new one. Odd that it's already fixed there, but good that it is. So I guess this issue/bounty is unfortunately invalid :(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ethresearch/eth-wiki/issues/11?email_source=notifications&email_token=AEENFXA7UDN5M3T23SZKYCLQGBAURA5CNFSM4IL4DCR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BHDJY#issuecomment-524448167, or mute the thread https://github.com/notifications/unsubscribe-auth/AEENFXHOUM4C24IHFDK5M5TQGBAURANCNFSM4IL4DCRQ .

sebastiantf commented 5 years ago

Suggesting to close this issue on GitHub and Gitcoin

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Cancelled

Work has been started.

These users each claimed they can complete the work by 267 years, 2 months from now. Please review their action plans below:

1) arbreton has started work.

Let me fix the documentation for this situation

Learn more on the Gitcoin Issue Details page.

ChrisChinchilla commented 5 years ago

@acolytec3 Do you have a line where you see this fix? It still looks the same to me in the new wiki repo.

acolytec3 commented 5 years ago

This cleans up the specific references to ether being sent by Call or Create operations that trigger an exception.

The only other place in the file that sort of deals with the reference issue is this line and vague enough to be useless -- "value may or may not be sent."

ChrisChinchilla commented 5 years ago

Ahh, I was looking in the wrong place. OK, cool, will cancel this bounty then, thanks!

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 35.0 DAI (35.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter