search

ethereum / eth-wiki

Ethereum Wiki
https://eth.wiki
48 stars 43 forks source link

Fix git identity #37

Open ChrisChinchilla opened 4 years ago

ChrisChinchilla commented 4 years ago

The "last edited by" field on wiki.js should reflect the last person who made a commit on Github, it currently doesn't.

ChrisChinchilla commented 4 years ago

Here's some examples… If i use git locally, my username shows, if I make changes with my user account on the site it's undefined or anon.

Screenshot 2020-05-20 13 51 48

bmann commented 4 years ago

WikiJS only supports a single commit identity by default, I believe.

ChrisChinchilla commented 4 years ago

@bmann Hmm, maybe that will change 🤞

wtf commented 4 years ago

Thanks for reporting this @ChrisChinchilla. We should definitely try to display the latest contributor (whether the edit is on eth.wiki or github) under "Last edited by". I believe the author name is correctly displayed when edits go from eth.wiki to github.com/ethereum/eth-wiki, so the issue is only for github -> eth.wiki.

Please feel free to add more issues needed for the git integration to work seamlessly and assign me to them.