ethereum / eth-wiki

Ethereum Wiki
https://eth.wiki
48 stars 43 forks source link

Update consensus-datastructures.md #46

Closed MicahZoltu closed 4 years ago

MicahZoltu commented 4 years ago
ChrisChinchilla commented 4 years ago

Thanks for the contribution @MicahZoltu just out of interest what are you referencing for these changes?

MicahZoltu commented 4 years ago

Code that I have written to interop with Ethereum. I originally tried using these docs but needed to ask around for additional information from client devs in order to actually build out my integrations, and I wanted to get that information I learned along the way encoded so future developers don't have to struggle like I did. 😄 If you think something is wrong, definitely tell me because it probably means my code is wrong too!

It is worth noting that some of the things I'm editing here is stuff I originally wrote a year or two ago and have since learned better. 😬

ChrisChinchilla commented 4 years ago

@MicahZoltu Thanks, it's more that it's quite hard for me to check the accuracy of some things for the same reason as you. Sometimes the only source of information was the old wiki (which may not be accurate), or asking people, which isn't ideal. I'm going to run this PR past people who know better than me and get some feedback on if the changes are correct. thanks again!