ethereum / ethash

188 stars 515 forks source link

Unable to go get this package #94

Closed congnt171 closed 7 years ago

congnt171 commented 7 years ago

go get github.com/ethereum/ethash

And get error

package github.com/ethereum/go-ethereum/pow: cannot find package "github.com/ethereum/go-ethereum/pow" in any of: /usr/lib/go-1.6/src/github.com/ethereum/go-ethereum/pow (from $GOROOT) /root/go/src/github.com/ethereum/go-ethereum/pow (from $GOPATH)

sammy007 commented 7 years ago

Can we finally sort out compatibility issues? Maybe it worth tagging version and publishing it on gopkg.in so side projects like open pool can rely on it?

sammy007 commented 7 years ago

https://github.com/ethereum/ethash/pull/93

mikeyb commented 7 years ago

go get github.com/ethereumproject/ethash go get github.com/ethereumproject/go-ethereum/pow etc..

Should work for you long term as classic chain will stay PoW/ethash for the foreseeable future.

karalabe commented 7 years ago

https://godoc.org/github.com/ethereum/go-ethereum/consensus/ethash

We've switched over to our Go implementation of ethash. I doubt we'll be maintaining the Go wrappers for this library any longer.

sammy007 commented 7 years ago

Okay, I am out from maintaining pool also. Cheers.

karalabe commented 7 years ago

Feel free to rage quit, but the proper way to depend on an external project in the Go world is to vendor it into your own repository. I am really sorry if we broke your code, it was not our intention. That is why I sent the link to the new implementation. I'd gladly help with integrating it.

karalabe commented 7 years ago

https://github.com/ethereum/ethash/pull/95 This should fix it for now all all eternity.

karalabe commented 7 years ago

This should be fixed now. Tried it and go get works for me. I've vendored in all go-ethereum dependencies so it should not break any time from now on. Please note however that a better one is available from the go-ethereum repository and it's highly recommended to use that since that will be the one receiving updates from now on.