search

ethereum / ethereum-buildbot

Ethereum Buildbot
https://build.ethdev.com/waterfall
MIT License
32 stars 36 forks source link

PR builders for Windows and Mac, and use Combined Status API #21

Closed debris closed 9 years ago

debris commented 9 years ago

I would like to have auto build on windows && mac for every pool request. It would be also nice, if we have three signs there (one for each platform), instead of one screen shot 2014-12-16 at 16 24 01 screen shot 2014-12-16 at 16 24 01 is that possible?

sveneh commented 9 years ago

You mean auto build on Win & Mac additionally to the current Linux build on PR? That would be important.

caktux commented 9 years ago

I'm fairly certain it's currently not possible to show multiple statuses like that, only the Combined Status API I'll be adding a PR builder for Mac and check with Nick for Windows.

sveneh commented 9 years ago

@caktux: Looking at the documentation for http://docs.buildbot.net/latest/manual/cfg-statustargets.html#status-GitHubStatus it seems that it doesn't support the combined Status API from Github because of missing context support (http://trac.buildbot.net/ticket/2876)

Meaning, we have to patch buildbot first to get this done, right?

caktux commented 9 years ago

Be careful about which docs you look into, "latest" is for Nine, the next major buildbot version to which we will upgrade once it's ready. Use "current" instead: http://docs.buildbot.net/current/manual/cfg-statustargets.html#status-GitHubStatus Looking into what needs to be done to support context, seems like both txgithub and GitHubStatus lack support for it. I'll still add PR builders for OSX and Win, even if it means a race condition for the final status as it stands, Linux builders will most probably finish first, followed by OSX then Windows.

caktux commented 9 years ago

Patched txgithub and GitHubStatus, all seems to be working great, closing