search

ethereum / ethereum-buildbot

Ethereum Buildbot
https://build.ethdev.com/waterfall
MIT License
32 stars 36 forks source link

cppcheck speedup #26

Closed jorisbontje closed 9 years ago

jorisbontje commented 9 years ago

cppcheck can be executed with the -j <jobs> option to run the process with multiple threads. Local testing suggests that this will lead to almost lineair speedup, given that the cores are available. Depending on the amount of cores on the buildslave, I'd suggest to provide -j <nr_cores> when calling cppcheck.

caktux commented 9 years ago

Has been set to -j 3 (nr_cores - 1 for some breathing room) while everything runs on the buildmaster, will set to $(cat /proc/cpuinfo | grep processor | wc -l) once on separate buildslaves.

caktux commented 9 years ago

extra_args can't handle setting the number of cores that way, I've set it to -j 6 for the new buildslave, but we could set a property and interpolate that instead. We have to keep in mind that all the builders are still on the same slave so it might be good not to use all cores

caktux commented 9 years ago

Let's keep those fixed, we know the number of processors on each buildslave and a slightly lower amount is better to leave resources for other builds. Cppcheck steps also has been moved to a separate builders so it doesn't slow down the main builds, closing.