ethereum / ethereum-buildbot

Ethereum Buildbot
https://build.ethdev.com/waterfall
MIT License
32 stars 36 forks source link

Linux Go develop/master deb i386/amd64: Please restart geth processes on upgrade #52

Open linagee opened 9 years ago

linagee commented 9 years ago

https://www.debian.org/doc/manuals/debian-faq/ch-pkg_basics.en.html

"Many 'postinst' scripts then execute any commands necessary to start or restart a service once a new package has been installed or upgraded."

Whenever I apt-get update / apt-get upgrade, for instance apache2, it always upgrades, then restarts processes.

Can we please include some (pbuilder?) magic that will:

1) at a minimum killall geth

2) better: see what options geth is running with, kill it, and restart it with those options again. (might be tricky if someone is using screen.)

I'm not sure exactly what/where to modify, but here are some places I found while searching: https://github.com/buildbot/buildbot/blob/master/master/buildbot/steps/package/deb/pbuilder.py https://github.com/ethereum/ethereum-buildbot/blob/master/factories/debian.py https://github.com/ethereum/ethereum-buildbot/blob/master/factories/go_ethereum.py

This would likely only be applicable to Linux/deb builds.