Open corwintines opened 1 year ago
This issue is stale because it has been open 45 days with no activity.
I see a split here... we have markdown files, and also React components... the md
files use ExpandableCard
a lot, which has these event tracks as props... My concern is passing an Object here could potentially make translations more difficult.
As for React components, I agree it would be nice to consolidate around a specific type
and ideally pass this through as an object.
I see this interface
declared inside src/lib/utils/matomo.ts
. I would suggest we:
type
instead of interface
type
to the types.ts
file for global usageeventCategory
, eventAction
, etc) and replace with passing an object containing these key-valuesPersonally would encourage we make this backward compatible with the markdown files where I think we should avoid the use of objects for the sake of translations.
This issue is stale because it has been open 30 days with no activity.
Hey @wackerow , would like to work on this task. Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!
Hey @0xshikhar, thanks! All TODO's above are still unfinished... This is mainly a clean-up type of task. In the end, the functionality should basically remain unchanged, we just want to standardize the way we use the Matomo event options
Assigning you!
Currently we have a few ways we are implementing Matomo events. Often passing props for
eventName
,eventCategory
,eventAction
. Instead of passing those as props, we should just standardize aroundMatomoEventOptions
type.MatomoEventOptions
for props being passed