ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.09k stars 4.83k forks source link

Standardize using MatomoEventOptions throughout codebase #10070

Open corwintines opened 1 year ago

corwintines commented 1 year ago

Currently we have a few ways we are implementing Matomo events. Often passing props for eventName, eventCategory, eventAction. Instead of passing those as props, we should just standardize around MatomoEventOptions type.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity.

wackerow commented 5 months ago

I see a split here... we have markdown files, and also React components... the md files use ExpandableCard a lot, which has these event tracks as props... My concern is passing an Object here could potentially make translations more difficult.

As for React components, I agree it would be nice to consolidate around a specific type and ideally pass this through as an object.

image

I see this interface declared inside src/lib/utils/matomo.ts. I would suggest we:

Personally would encourage we make this backward compatible with the markdown files where I think we should avoid the use of objects for the sake of translations.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 30 days with no activity.

0xshikhar commented 3 weeks ago

Hey @wackerow , would like to work on this task. Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

wackerow commented 3 weeks ago

Hey @0xshikhar, thanks! All TODO's above are still unfinished... This is mainly a clean-up type of task. In the end, the functionality should basically remain unchanged, we just want to standardize the way we use the Matomo event options

Assigning you!