search

ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.04k stars 4.78k forks source link

Suggest a wallet: KrystalWallet #10076

Closed KrystalWallet closed 1 year ago

KrystalWallet commented 1 year ago

Wallet name

Krystal Wallet

Wallet description

Krystal is the simplest web3 wallet for everyone. On a single application, access cutting-edge portfolio management & market insights tools, swap & bridge tokens, earn passive income and participate in token sales via its IDO launchpad, KrystalGO. Additionally, users earn points and rewards from in-app activities as part of its loyalty program.

Wallet logo

Krystal_icon_512

Background color for brand logo

000000

URL to the project

https://krystal.app/

When did the wallet go live to users?

15 April 2021

Does the wallet have an active development team?

Yes

Is the wallet globally accessible?

Yes, beside these countries Cuba, Palestine, Russia, Syria, Yemen, Iran, Zimbabwe, Democratic People's Republic of Korea (DPRK), United States of America, People’s Republic of China, Hong Kong SAR, Macau SAR, Singapore, Myanmar

Is the wallet available in multiple languages?

No response

What social links are there for the project?

https://twitter.com/KrystalWallet

Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)?

Yes, both Android and iOS https://krystal.app.link

Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)?

No response

Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)?

No response

Is it a hardware wallet?

No response

Is the source code for the wallet fully open-source?

No response

What license is the wallet software released under?

No response

Who holds the private keys?

Users

Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible

No response

Has the wallet's smart contract code or security modules been audited?

No response

Does the wallet have an internal security team?

No response

Any other security testing that should be noted?

No response

Scam protection?

No response

Does the wallet support connecting to a hardware wallet?

No

Does the wallet support WalletConnect?

Yes

Does the wallet support importing Ethereum RPC endpoints?

No response

Does the wallet support viewing and interacting with NFTs?

Yes

Does the wallet support connecting to Ethereum applications?

https://docs.krystal.app/features/dapp-browser

Does the wallet support staking directly?

https://docs.krystal.app/features/earn

Does the wallet support swaps directly?

https://docs.krystal.app/features/swap

Does the wallet support multi-chain networks?

https://docs.krystal.app/features/multichain-features

Does the wallet support Ethereum layer 2 networks?

Yes

Does the wallet allow the user to customize gas fees?

Yes

Does the wallet support sending transactions to ENS addresses?

No response

Does the wallet support importing or automatically querying and displaying ERC-20 tokens?

No response

Does the wallet support EIP-1559 (type 2) transactions?

No response

Does the wallet have fiat on-ramps through credit/debit cards, wire transfers, or bank transfers (ACH)?

No response

Does the wallet support withdrawals to fiat?

No response

Is the wallet a multi-signature wallet?

No response

Does the wallet support social recovery?

No response

Who can the ethereum.org team can contact regarding the wallet in future?

No response

Does the wallet have a dedicated support team?

No response

What educational resources/documentation do you provide to users?

No response

Does the wallet have any integrated tools not mentioned above?

No response

Would you like to work on this issue?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity.

KrystalWallet commented 1 year ago

@nhsz @chuyeow @matthieu @shazow @jpanachida Please help us with this request

cryptocoinpurse commented 1 year ago

up

corwintines commented 1 year ago

@KrystalWallet

This has been discussed earlier in this PR when we listed you on the dapps page as the outcome. Has there been any meaningful changes to the application since then that you could highlight?

KrystalWallet commented 1 year ago

Yes, since March 2023 we have rebranded and position us as a wallet, all of our media channels have been changed to Krystal Wallet. We also fully focusing to build as a wallet, so you can see our app is similar to other wallets like 1inch, Metamask, Bitkeep etc...

KrystalWallet commented 1 year ago

@corwintines friendly reminder

KrystalWallet commented 1 year ago

up

corwintines commented 1 year ago

@KrystalWallet I don't think just rebranding addresses the issues that had come up with your app in the past https://github.com/ethereum/ethereum-org-website/issues/6999. I don't think you really answered my question of what has changed other than a rebrand, which isn't enough.

There is a lot of no response in this issue, which leads me to believe this wasn't even fully filled out. I'm not willing to go through and find the answers to all the no responses that are left here. There are a lot of wallets that we have rejected due to not sharing security audits with us, as well as their source code, and I'm noticing the same issue here. Given hacks going on in wallets, this is something I need to see before I'm willing to consider a wallet.

The interface of the app is still quite confusing. The main call to action is a portfolio manager, not a wallet (regardless of branding). With the goal of this page being easily onboarding users to a wallet, this really doesn't fit that goal.

I am rejecting this with the above reasoning. Will give another core member a chance to review before closing.

minimalsm commented 1 year ago

Hey folks!

Thanks for creating this, and sorry for the delay in reviewing ❤️

I don’t think listing Krystal as a wallet on ethereum.org makes sense.

Specifically, I don’t think linking to https://krystal.app/ is a good option for the users this pages is intending to help onboard to Ethereum, i.e., someone who is:

  1. Looking for a wallet
  2. New to the ecosystem

As we discussed with @LoganDWH, when he requested we list Krystal on the wallets page last year (#6999):

All of this makes it rather confusing for someone taking their first steps into acquiring a wallet, which is counterproductive to our goal of providing a "seamless onboarding experience" for new users, as per our listing criteria.

I hope this clarifies our thinking here. I'm open to discussing any of my points further, but I’m going to close out this issue.

KrystalWallet commented 1 year ago

Thanks you guys for your feedbacks, i will elaborate it to the team.