ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.01k stars 4.76k forks source link

Banner for out-of-date translations not displaying #10694

Open wackerow opened 1 year ago

wackerow commented 1 year ago

Describe the bug

When exploring #9306 I noticed that the banner we display on translated pages that are not fully up-to-date with the English copy is not being displayed.

To reproduce

  1. Go to https://ethereum.org/de/developers/docs/oracles
  2. Notice that no banner is displayed

To further demonstrate, notice the second H2 has a hash link of #what-is-an-oracle on the German (de) version, but #what-is-a-blockchain-oracle on the English version. This difference should trigger the banner.

Expected behavior

When content structure has changed with the English version, the translated versions that no longer match the same structure should result in a banner being displayed informing users that there is more up-to-date content available in English.

This is not for the case when the page has not yet been translated at all... this presents a different banner which continues to work appropriately.

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

wackerow commented 1 year ago

https://ethereum.org/fr/

🤔 Hm... just noticing the French homepage is displaying the banner appropriately, but still doesn't seem to be working appropriately throughout.

image
wackerow commented 1 year ago

(Note that #10696 will bring the French homepage up-to-date with English so this will go away after that hits production... see above screenshot)

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity.