search

ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
4.99k stars 4.73k forks source link

SideNav #10744

Open pettinarip opened 1 year ago

pettinarip commented 1 year ago

Our current SideNav used in the developer docs section, needs to be refactored to use the new DS styles

image

Nagapadmini7 commented 1 year ago

I can work on this issue

ameeetgaikwad commented 12 months ago

@pettinarip would like to work on this issue

pettinarip commented 11 months ago

Hi @ameeetgaikwad! assigning it to you, thanks!

pettinarip commented 11 months ago

@ameeetgaikwad pls consider using the Accordion for this implementation

TylerAPfledderer commented 11 months ago

@ameeetgaikwad please do not ask for review in issues. That's the purpose of the Pull Request. Also, can't do a proper review based off of a screenshot. 😸

Hmmm hey @pettinarip, we might be getting too far ahead in making this an available issue. Getting a PR going now for this might clash with getting the accordion theme online... particularly because there is #10936 open. 🤔

I would assume that this sidenav component is dependent on that other PR's completion, no?

ameeetgaikwad commented 11 months ago

@TylerAPfledderer so sorry, I'll delete that comment.

pettinarip commented 11 months ago

Correct. Good point @TylerAPfledderer. This PR will be on hold until we merge the Accordion implementation.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 45 days with no activity.

wackerow commented 4 months ago

Circling back, this hasn't been forgotten... #10936 has had a couple updates, trying to get that in then will come back to this one.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity.

corwintines commented 1 month ago

Removing stale tag since this has a draft PR in progress

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 30 days with no activity.

minimalsm commented 2 days ago

Reassigning this to @pettinarip as he has an open (draft) PR here.