Refactor Quiz Hub logic

ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.

https://ethereum.org/

MIT License

5k stars 4.76k forks source link

Closed pettinarip closed 1 month ago

pettinarip commented 1 year ago

The current Quiz Hub logic is crashing when we add new quizzes to it.

Pull all logic from quiz component higher up the component order as possible to help create component re-usability (preferably to the quiz hub page).
Reorganize the logic and condense / refactor where necessary
The localStorage issue should be solved after the above two objectives are met, and not just creating a patch.
Consider the use of useLocalStorage from useHooks-ts as a more robust version of the hook already in the project.

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 45 days with no activity.

TylerAPfledderer commented 11 months ago

@pettinarip commenting for assignment.

Public note: based on private discussion, this issue is expected to be part of a larger refactor of the logic for the quizzes.

Primary goals for quiz hub components:

Pull all logic from quiz component higher up the component order as possible to help create component re-usability (preferably to the quiz hub page).
Reorganize the logic and condense / refactor where necessary
The localStorage issue should be solved after the above two objectives are met, and not just creating a patch.
Consider the use of useLocalStorage from useHooks-ts as a more robust version of the hook already in the project.

Pablo: would you prefer a new GH issue be created to address the complete refactor, and note this localStorage issue as a dependency?

pettinarip commented 11 months ago

@TylerAPfledderer great!

I've updated the title & description to match what you wrote 💯

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 45 days with no activity.

TylerAPfledderer commented 9 months ago

My assignment is retained here, but addressing this issue over in the Next fork repo, per private discussion.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 30 days with no activity.

TylerAPfledderer commented 1 month ago

@pettinarip I think this should be considered closed

pettinarip commented 1 month ago

@TylerAPfledderer thanks, yes, this refactor is not going to be done for now. For ref. this was the progress done #11933.