ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.02k stars 4.77k forks source link

Unknown paths (404s) redirect user to English #12471

Open Codex-Bugmenot opened 6 months ago

Codex-Bugmenot commented 6 months ago

Describe the bug

In the 404 page with text "We couldn't find that page" the link return home is expected to redirect to "https://ethereum.org/en/" or "https://ethereum.org/" but it redirects you to "https://ethereum.org/en/enindex/" which again is a non-existent page

To reproduce

  1. Visit a 404 page , i used "https://ethereum.org/en/1"
  2. Click on return home link or ethereum logo(top-left)
  3. Now observe you've been redirected to "https://ethereum.org/en/enindex" instead of home page

Expected behavior

When clicking on return home link or ethereum logo from a 404 page it should redirect to home page instead of "https://ethereum.org/en/enindex" page

Screenshots

404Page 404enIndex

Desktop (please complete the following information)

Smartphone (please complete the following information)

-Browser: Brave

Additional context

No response

Would you like to work on this issue?

tomasgrusz commented 6 months ago

I'd like to work on this issue, can I be assigned?

wackerow commented 6 months ago

Thanks @Codex-Bugmenot for reporting! Indeed getting the same result on my end—in Brave and Safari.

@tomasgrusz Thanks for volunteering to help! Just assigned you, let us know if you hit issues

@all-contributors please add @Codex-Bugmenot for bug report

allcontributors[bot] commented 6 months ago

@wackerow

I've put up a pull request to add @Codex-Bugmenot! :tada:

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

Codex-Bugmenot commented 6 months ago

I think i just found another small issue in the 404 page should i report it here or open another issue?

tomasgrusz commented 6 months ago

I think there's another small issue in the 404 page should i report it here or open a nother issue?

what's the issue? I already have a PR ready for review, so if it's too different, let's create a new one. Otherwise I think it could be addressed here.

Codex-Bugmenot commented 6 months ago

It's definitely different (not related to redirection), ill open a new issue and do the @tomasgrusz there 👍

Codex-Bugmenot commented 6 months ago

@tomasgrusz , here is the link to the other small issue i mentioned about https://github.com/ethereum/ethereum-org-website/issues/12505

wackerow commented 6 months ago

Yes, a new issue is perfect, thanks @Codex-Bugmenot.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 45 days with no activity.

wackerow commented 3 months ago

Hey @tomasgrusz! Going to un-assign for now, but please feel free to comment and jump back in if you'd like

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity.

corwintines commented 2 months ago

Removing stale tag

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity.

wackerow commented 1 month ago

Elevating as this breaks all 404 experiences, and has been problematic for a while.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 30 days with no activity.