search

ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.12k stars 4.85k forks source link

Inconsistency between "Accounts" and "Transactions" doc pages #12897

Open ckoopmann opened 6 months ago

ckoopmann commented 6 months ago

Describe the bug

On the documentation for "accounts" it says:

An Ethereum account is an entity with an ether (ETH) balance that can send transactions on Ethereum. Accounts can be user-controlled or deployed as smart contracts.

This sentence implies that smart contract accounts can send "transactions", which contradicts the definition of "transaction" on the corresponding doc page:

An Ethereum transaction refers to an action initiated by an externally-owned account, in other words an account managed by a human, not a contract.

It seems the term "transaction" is used incorrectly on the accounts page so I'd suggest replacing it with an alternative such as "call" or "message" .

To reproduce

  1. Read doc page regarding accounts
  2. Read doc page regarding transactions

Expected behavior

Terms should be used consistently across the documentation pages.

Screenshots

image image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

corwintines commented 6 months ago

Thanks @ckoopmann. I agree, this could use some updates. I think what is on the accounts page is correct from what you shared. I think the transactions page. Transactions can be submitted by both smart contracts and EOA's, so this should be updated.

I see you put you are interested. I will assign this to you :) Let me know if you need anything.

wackerow commented 5 months ago

Hey @ckoopmann! Just checking in, any update here? Any way we can help?

ckoopmann commented 5 months ago

Thanks @ckoopmann. I agree, this could use some updates. I think what is on the accounts page is correct from what you shared. I think the transactions page. Transactions can be submitted by both smart contracts and EOA's, so this should be updated.

I see you put you are interested. I will assign this to you :) Let me know if you need anything.

From my understanding the transactions page is correct. Smart contract accounts cannot initiate ethereum Transactions as there are defined on the transactions page. As mentioned above I think the word "transaction" is misused on the accounts page and I'd change that page to use the word "message" instead.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 30 days with no activity.

lukassim commented 3 months ago

Hey @ckoopmann, are you still interested in working on this? Your proposed changes look good, you've been assigned to the issue so if you want to open a PR with this update, that would be great... if not, let us know and we can unassign you and open it up to the community

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity.

corwintines commented 1 month ago

Opening this back up for contribution

0xshikhar commented 1 month ago

Hey @corwintines, can you assign me that issue - i will like to update it.

github-actions[bot] commented 5 days ago

This issue is stale because it has been open 30 days with no activity.