search

ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
4.9k stars 4.67k forks source link

Create stories for Header components #13050

Open corwintines opened 1 month ago

corwintines commented 1 month ago

Create stories for the following header components:

amit-ksh commented 1 week ago

hi @corwintines, I'd like to work on this

TylerAPfledderer commented 1 week ago

Hey @amit-ksh! Making a quick comment here for reference for you and @corwintines.

In review of these components, I believe the only one marked for visual testing would be the Nav, which is fine to start with since it couples the initial rendering of Search and LanguagePicker.

Two thoughts here if we are considering individual stories for this GH issue with Search and LanguagePicker

  1. There only needs to be one story for each, but as an interactive test with the play function so that Chromatic can take a snapshot of the open modals.
  2. For Search, make sure environment variables used are available in the storybook environment with the testing api keys provided by DocSearch. If not having these keys available in the main .env file, then need to look to the Storybook Config.