Closed pettinarip closed 3 months ago
Name | Link |
---|---|
Latest commit | aa21459e46a1510b34d64c21212ac552362c6e75 |
Latest deploy log | https://app.netlify.com/sites/ethereumorg/deploys/6679c034dc877f0008e7f5f6 |
Deploy Preview | https://deploy-preview-13205--ethereumorg.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
7 paths audited Performance: 51 (🟢 up 4 from production) Accessibility: 92 (no change from production) Best Practices: 84 (🔴 down 8 from production) SEO: 93 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
@pettinarip @TylerAPfledderer I think this will be ready now
I added the glossary-tooltip
namespace into .storybook/i18next.ts
, and changed the term from big-endian
to bridge
since big-endian
isn't in glossary-tooltip.json.
@nloureiro Mind approving these changes in Chromatic if they look okay to you?
@pettinarip @TylerAPfledderer I think this will be ready now
I added the
glossary-tooltip
namespace into.storybook/i18next.ts
, and changed the term frombig-endian
tobridge
sincebig-endian
isn't in glossary-tooltip.json.
Nice! thanks!
@nloureiro Mind approving these changes in Chromatic if they look okay to you?
looks good to me. approved on Chromatic :)
In recent changes, we have changed a bit how we display the heading on the Glossary Definition component, and this affects the Glossary Tooltip styles.
Description
This PR fixes the style issues by:
Bonus: added a new story for the open state of GlossaryTooltip to avoid getting these regressions again.