ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.04k stars 4.78k forks source link

Fix heading styles in Glossary Definition and Tooltip #13205

Closed pettinarip closed 3 months ago

pettinarip commented 3 months ago

In recent changes, we have changed a bit how we display the heading on the Glossary Definition component, and this affects the Glossary Tooltip styles.

Description

This PR fixes the style issues by:

Bonus: added a new story for the open state of GlossaryTooltip to avoid getting these regressions again.

netlify[bot] commented 3 months ago

Deploy Preview for ethereumorg ready!

Name Link
Latest commit aa21459e46a1510b34d64c21212ac552362c6e75
Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6679c034dc877f0008e7f5f6
Deploy Preview https://deploy-preview-13205--ethereumorg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
7 paths audited
Performance: 51 (🟢 up 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 84 (🔴 down 8 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

corwintines commented 3 months ago

@pettinarip @TylerAPfledderer I think this will be ready now

I added the glossary-tooltip namespace into .storybook/i18next.ts, and changed the term from big-endian to bridge since big-endian isn't in glossary-tooltip.json.

wackerow commented 3 months ago

@nloureiro Mind approving these changes in Chromatic if they look okay to you?

https://www.chromatic.com/review?appId=63b7ea99632763723c7f4d6b&number=13205&type=linked&view=changes

pettinarip commented 3 months ago

@pettinarip @TylerAPfledderer I think this will be ready now

I added the glossary-tooltip namespace into .storybook/i18next.ts, and changed the term from big-endian to bridge since big-endian isn't in glossary-tooltip.json.

Nice! thanks!

nloureiro commented 3 months ago

@nloureiro Mind approving these changes in Chromatic if they look okay to you?

https://www.chromatic.com/review?appId=63b7ea99632763723c7f4d6b&number=13205&type=linked&view=changes

looks good to me. approved on Chromatic :)