ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.

https://ethereum.org/

MIT License

4.89k stars 4.67k forks source link

Closed pettinarip closed 4 days ago

pettinarip commented 1 week ago

Description

Tackles issues detected while testing the chart.js migration.

Home page charts

app crashing on production build when user changes the range period
disabled labels because for some reason, some times, they were displayed even though we are not using labels in this case

Energy consumption chart

better responsive styles (docs) - left the aspectRatio unset given that we want the chart to adapt to its parent size
adjust chart height for different resolutions
rtl support
fixed a few typing issues

Added stories for both.

netlify[bot] commented 1 week ago

Name	Link
Latest commit	ffd6e419b18b81a6f39cf03de0430cf9925cb708
Latest deploy log	https://app.netlify.com/sites/ethereumorg/deploys/6673e2577256170008da6a2d
Deploy Preview	https://deploy-preview-13212--ethereumorg.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	7 paths audited Performance: 42 (🟢 up 4 from production) Accessibility: 92 (no change from production) Best Practices: 83 (🔴 down 9 from production) SEO: 93 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

wackerow commented 1 week ago

Looks good, @nhsz this targets your branch though so I'll let you merge when ready