search

ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
4.89k stars 4.67k forks source link

style(theme/Tag): set background style on close button hover #13237

Closed TylerAPfledderer closed 2 days ago

TylerAPfledderer commented 3 days ago

Description

Updates the close button style on hover to sync with the DS.

This is not a complete sync — see the "Normal" and "Tag" Solid variants. This provided additional complication that already exists in the theming.

Related Issue

netlify[bot] commented 3 days ago

Deploy Preview for ethereumorg ready!

Name Link
Latest commit 57e76efff574ba4c6b29259fac2af6fa4f6967ae
Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/667c0655969c2b00087288a1
Deploy Preview https://deploy-preview-13237--ethereumorg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 7 paths audited
Performance: 45 (🔴 down 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

TylerAPfledderer commented 3 days ago

@pettinarip and @nloureiro, I would like to try and review the tag styling with you, and present an alternative that I have made (Pablo has seen this).

What makes creating the styling in the code with all the variants is inconsistency in how all the different colors are being used. The generates a bloated set of styles that have to be hard-coded. I would like to present a solution that reduces the colors used to just the two different shades in the palette for each "status" type which would also improve a11y in the color contrast, especially with this hover styles of the close button.

pettinarip commented 3 days ago

@pettinarip and @nloureiro, I would like to try and review the tag styling with you, and present an alternative that I have made (Pablo has seen this).

What makes creating the styling in the code with all the variants is inconsistency in how all the different colors are being used. The generates a bloated set of styles that have to be hard-coded. I would like to present a solution that reduces the colors used to just the two different shades in the palette for each "status" type which would also improve a11y in the color contrast, especially with this hover styles of the close button.

Sounds good to me!

FYI new colors are coming to the DS. Just saying for context but I don't think it will affect what you're suggesting here.