search

ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.04k stars 4.79k forks source link

Incorrect Image Paths in README.md #13308

Closed Shiva-Sai-ssb closed 2 months ago

Shiva-Sai-ssb commented 3 months ago

Describe the bug

The README.md file contains broken image links due to changes in file paths.

To reproduce

  1. Go to the README.md file on the main repository page.
  2. Locate the Ethereum logo, Netlify preview image, and POAP logo.
  3. Observe that these images are not displaying correctly.

Expected behavior

All images in the README.md file should display correctly with the updated file paths.

Screenshots

  1. Pic-1

  2. Pic-2

  3. Pic-3

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

  1. The Ethereum logo path should be changed from ./public/assets/eth-transparent.png to ./public/images/assets/eth-transparent.png.

  2. The Netlify preview image path should be changed from public/preview-deploy.png to public/images/preview-deploy.png.

  3. The POAP logo path should be changed from public/poap-logo.svg to public/images/poap-logo.svg.

Moreover, only GitPOAP is given to contributors upon making their first pull request on merging it into the repo, while OATs are given to contributors for making significant contributions to the repo, including translations. I think it would be beneficial to replace the section specifically mentioning POAP with a section describing OATs instead.

Would you like to work on this issue?

wackerow commented 3 months ago

Thanks for raising @Shiva-Sai-ssb! I've put up a patch for this

wackerow commented 3 months ago

@all-contributors please add @Shiva-Sai-ssb for bug report

allcontributors[bot] commented 3 months ago

@wackerow

I've put up a pull request to add @Shiva-Sai-ssb! :tada: