ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5k stars 4.76k forks source link

fix event tracking: wallet page #13420

Closed konopkja closed 1 week ago

konopkja commented 1 month ago

Is your feature request related to a problem? Please describe.

currently there is missing event tracking on one button and also other tracking should be changed on https://ethereum.org/en/wallets/

Describe the solution you'd like

Screenshot 2024-07-18 at 16 44 31

the two buttons on the image above (in the header of the page) are missing event tracking.

Event Category Header buttons

Event Action click

Event Name Find_wallet How_to_use_wallet

Screenshot 2024-07-18 at 16 46 35

these two buttons tracking should be changed not to use "value"

Original Event Category Link

Event Action Clicked Event Name

Clicked on internal link Event Value /guides/how-to-create-an-ethereum-account/

Change to Event Category Link

Event Action Clicked

Event Name Create_eth_acc How_to_use_wallet

Screenshot 2024-07-18 at 16 49 23

Same issue here and the existing tracking should be changed

Change to Event Category Link

Event Action Clicked_external

Event Name protecting_yourself the_keys_to_keeping_crypto_safe

Describe alternatives you've considered

NA

Additional context

No response

Would you like to work on this issue?

MahendraBishnoi29 commented 1 month ago

assign it to me @wackerow

rohitt-gupta commented 1 month ago

@konopkja @corwintines Created a PR for the same, Please check/review and merge it. Let me know if you need any help regarding this PR

MahendraBishnoi29 commented 1 month ago

@konopkja @corwintines Created a PR for the same, Please check/review and merge it. Let me know if you need any help regarding this PR

@rohitt-gupta I'm already working on this issue, please check that if someone has been assigned for the issue or not before contributing :)

@wackerow @corwintines

corwintines commented 1 week ago

@rohitt-gupta as mentioned, if someone is assigned please don't snipe it from them

I will review it for now since its the only open PR. @MahendraBishnoi29 not sure your progress here and if you are close, I will favor yours.

MahendraBishnoi29 commented 1 week ago

@rohitt-gupta as mentioned, if someone is assigned please don't snipe it from them

I will review it for now since its the only open PR. @MahendraBishnoi29 not sure your progress here and if you are close, I will favor yours.

since you've already merged the PR so I'll stop working on this one :)