fix: LanguagePicker max height

ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.

https://ethereum.org/

MIT License

5.04k stars 4.78k forks source link

fix: LanguagePicker max height #13942

Closed wackerow closed 3 days ago

wackerow commented 5 days ago

Description

Moves the max-height property to the Command parent for the Language Picker component
Adjusts height to use calc allowing menu to drop to just above the feedback widget, regardless of screen height

Related Issue

Fixes bug where the "Learn more" section at the bottom of the LanguagePicker was falling off the bottom edge of the screen on shorter displays/windows.

With fix:

Preview link

https://deploy-preview-13942--ethereumorg.netlify.app/en/

netlify[bot] commented 5 days ago

Deploy Preview for ethereumorg ready!

Name	Link
Latest commit	c83e6cefc24acad65e404f87476d9a24e68b2a9b
Latest deploy log	https://app.netlify.com/sites/ethereumorg/deploys/66f1ed8ffcdf1f0008af4d9f
Deploy Preview	https://deploy-preview-13942--ethereumorg.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	7 paths audited Performance: 44 (🔴 down 2 from production) Accessibility: 93 (no change from production) Best Practices: 89 (🔴 down 9 from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.