Open pettinarip opened 1 month ago
@pettinarip I'm currently handling all of the Quiz components
@TylerAPfledderer gotcha! added your name next to them, ty.
@pettinarip Please assign me the Banners/ContributorsQuizBanner.tsx
component.
Assigned @saurabhburade 👍🏼
Please assign the Contributors and DataProductCard to me @pettinarip Thanks
Please assign the Contributors and DataProductCard to me @pettinarip Thanks
Yey! awesome, assigned! let me know if you need any clarification or help 💪🏼
Please assign the Contributors and DataProductCard to me @pettinarip Thanks
Yey! awesome, assigned! let me know if you need any clarification or help 💪🏼
TwImage is not working with remote URLs , getting this error cos its using next/image under the hood Error: Invalid src prop (https://avatars2.githubusercontent.com/u/364566?v=4) on
next/image, hostname "avatars2.githubusercontent.com" is not configured under images in your
next.config.js See more info: https://nextjs.org/docs/messages/next-image-unconfigured-host
should I add avatars2.githubusercontent.com
to next.config.js or use the bare img
element, this also shows a warning Using
could result in slower LCP and higher bandwidth. Consider using
from
next/imageto automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element
but it works
@pettinarip
Right @Baystef lets use the img
tag for now. You can leave the warning.
Hi @pettinarip can you assign the ProductCard.tsx
migration to me? Thanks!
hey @pettinarip could you please assign ExpandableCard.tsx
's migration to me. Thanks
@yashtotla @kushagrasarathe thanks for helping! assigned, thanks
hey @pettinarip have made a pr for ExpandableCard.tsx
, meanwhile can you assign me these remaining card components please:
GhostCard
HorizontalCard
Layer2ProductCard
RoadmapActionCard
Thanks 🙌
Assigned @kushagrasarathe and @saurabhburade!
Quick reminder: create a separate PR for each component please. Thank you guys!
Hi @pettinarip , I can work on these files. Please assign me.
Hi @pettinarip ,
I would like to work on these files , could you please assign me.
@pettinarip please assign GitStars
and History/NetworkUpgradeSummary.tsx
to me. Thanks
I've updated the list @ashiskumar-1999 @sahildotdev @Baystef ✌🏼
Hi @pettinarip can you assign the StablecoinsTable.tsx
migration to me?
Thanks
@pettinarip can you assign the ProductList.tsx
migration to me?
@0xgun assigned! 💪🏼 For this one,lets use the shadcn table component.
@pettinarip can you assign the
ProductList.tsx
migration to me?
Done! thanks @yashtotla
@pettinarip Please assign me DocLink
&DocsNav
.
FYI added more components to migrate from the /Staking
and /Translatathon
folders.
@pettinarip please assignTranslatathon/ApplyNow.tsx
LocalCommunitiesList
and DatesAndTimeline
components to me. Thanks
hey @pettinarip like to work on those file. Can you please assign
Translatathon/TranslatathonInANutshell.tsx
Translatathon/TranslatathonCalendar.tsx
Translatathon/TranslationHubCallout.tsx
Translatathon/TranslatathonBanner.tsx
Translatathon/StepByStepInstructions.tsx
Assigned @Sambit03. Thanks, let me know if you have any questions.
Assigned @Sambit03. Thanks, let me know if you have any questions.
@pettinarip please assign
Roadmap/RoadmapImageContent
Staking/StakingHowSoloWorks
Staking/StakingProductsCardGrid/index.tsx
Staking/StakingStatsBox
Staking/StakingCommunityCallout
Staking/StakingLaunchpadWidget
Staking/StakingGuides
Staking/WithdrawalsTabComparison
to me
hey @pettinarip
please assign Trilemma/index.tsx
component to me.
@Baystef I've assigned you the first 4 for now, just to give others a chance to join in the meantime. Once you are done with them, I can assign the rest if no one else has requested them.
Thanks!
Assigned @atharv-av!
Hey @pettinarip pls assign Staking/StakingGuides.tsx
to me
Hey @pettinarip pls assign
Staking/StakingGuides.tsx
to me
Done! is yours, thanks for helping 🚀 Let us know if you need help.
hello @pettinarip
please assign Layer2/Layer2Onboard.tsx
to me
@Baystef I've assigned you the first 4 for now, just to give others a chance to join in the meantime. Once you are done with them, I can assign the rest if no one else has requested them.
- Roadmap/RoadmapImageContent
- Staking/StakingHowSoloWorks
- Staking/StakingProductsCardGrid/index.tsx
- Staking/StakingStatsBox
Thanks!
PR up for the 4
Assigned @atharv-av!
@Baystef I've assigned you the first 4 for now, just to give others a chance to join in the meantime. Once you are done with them, I can assign the rest if no one else has requested them.
- Roadmap/RoadmapImageContent
- Staking/StakingHowSoloWorks
- Staking/StakingProductsCardGrid/index.tsx
- Staking/StakingStatsBox
Thanks!
PR up for the 4
Wow, that was fast, thanks @Baystef. I'll check those PRs soon.
In the meantime, I've assigned the other components you requested before.
Assigned @atharv-av!
Please check the PR.
Hi @pettinarip,
please assign SocialListItem.tsx
to me, thanks.
Done @yun-chiao! thanks!
Hi @pettinarip , please assign ActionCard.tsx to me, thanks!
@Baystef I've assigned you the first 4 for now, just to give others a chance to join in the meantime. Once you are done with them, I can assign the rest if no one else has requested them.
- Roadmap/RoadmapImageContent
- Staking/StakingHowSoloWorks
- Staking/StakingProductsCardGrid/index.tsx
- Staking/StakingStatsBox
Thanks!
PR up for the 4
Wow, that was fast, thanks @Baystef. I'll check those PRs soon.
In the meantime, I've assigned the other components you requested before.
- Staking/WithdrawalsTabComparison.tsx
- Staking/StakingLaunchpadWidget.tsx
- Staking/StakingCommunityCallout.tsx
@pettinarip, when OldText is removed and replaced with a normal p
tag, the global styles of OldText gets lost obviously.
margin-bottom: 1.45rem;
line-height: 1.6rem;
So my question is
should I add a global p
tag style with the exact style OldText was using
or add the tailwind style on individual p
tags
or should I leave it squashed as is and you guys will handle it globally?
@pettinarip
Would like to work on TranslationBannerLegal.tsx
, TranslationBanner.tsx
, TranslationLeaderboard.tsx
Please assign.
@pettinarip, when OldText is removed and replaced with a normal
p
tag, the global styles of OldText gets lost obviously.margin-bottom: 1.45rem; line-height: 1.6rem;
So my question is should I add a global
p
tag style with the exact style OldText was using or add the tailwind style on individualp
tags or should I leave it squashed as is and you guys will handle it globally?
@Baystef to simplify the migration, we try to match production as much as possible. For now, we won't set a global style for the paragraph as we don't have much consistency in them. What I would suggest is that you try to control the spacing from the parent using gap
. If not, you could set the margin on each paragraph.
Another thing I would like to see if possible is the usage one of the tw sizes/scale, instead of the custom 1.45rem
, feel free to use mb-6
(1.5rem) or whatever works best in this case.
@pettinarip
Would like to work on
TranslationBannerLegal.tsx
,TranslationBanner.tsx
,TranslationLeaderboard.tsx
Please assign.
Hi @ameeetgaikwad 👋🏼 happy to see you around!
I've assigned those to you. Ty
Please assign these to me @pettinarip
@Baystef assigned. Will review those new PRs soon, thanks!
@pettinarip hey! i want to work on "RollupProductDevDoc.tsx"
Its yours! @cqw-acq thanks. Let us know if you need help.
Hey @pettinarip can you assign me stat/index.tsx
Description
As part of our Q3 roadmap, this issue tracks the progress of the Shadcn/Tailwind migration.
How to contribute
If you’d like to help with the component migration, please follow these steps:
Tips & Guidance
components/ui
@chakra-ui/react/Icon
⇒ just use the exported svg component from react-icons instead<MdMenu className="text-2xl" />
<p>
tag<h1>
,<h2>
, etc. tagsLink
component defined incomponents/ui/Link
components/ui/buttons/Button
TwImage
fromcomponents/Image
components/ui/flex
as much as possibletailwind.config.ts
file. At the review stage, we will analyze & try to replace old theme colors with new colors from the Design System.Done
In review
Pending
src/components
src/components/Staking
src/components/Translatathon