ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.11k stars 4.84k forks source link

Shadcn/Tailwind migration #13946

Open pettinarip opened 1 month ago

pettinarip commented 1 month ago

Description

As part of our Q3 roadmap, this issue tracks the progress of the Shadcn/Tailwind migration.

How to contribute

If you’d like to help with the component migration, please follow these steps:

  1. Read the following “Tips & Guidance” section for basic things to keep in mind while doing the migration.
  2. Leave a comment here asking which component you would like to work out.
  3. We assign you to the file by adding your handle next to the file name in the list.
    • If you were assigned to multiple files then create a separate PR for each component. It will make the testing and review process much simpler and more organized.
  4. Once you finish it (PR merged), we’ll mark it as done.
  5. Repeat!

Tips & Guidance

Done

In review

Pending

src/components

src/components/Staking

src/components/Translatathon

TylerAPfledderer commented 1 month ago

@pettinarip I'm currently handling all of the Quiz components

pettinarip commented 1 month ago

@TylerAPfledderer gotcha! added your name next to them, ty.

saurabhburade commented 1 month ago

@pettinarip Please assign me the Banners/ContributorsQuizBanner.tsx component.

pettinarip commented 1 month ago

Assigned @saurabhburade 👍🏼

Baystef commented 1 month ago

Please assign the Contributors and DataProductCard to me @pettinarip Thanks

pettinarip commented 1 month ago

Please assign the Contributors and DataProductCard to me @pettinarip Thanks

Yey! awesome, assigned! let me know if you need any clarification or help 💪🏼

Baystef commented 1 month ago

Please assign the Contributors and DataProductCard to me @pettinarip Thanks

Yey! awesome, assigned! let me know if you need any clarification or help 💪🏼

TwImage is not working with remote URLs , getting this error cos its using next/image under the hood Error: Invalid src prop (https://avatars2.githubusercontent.com/u/364566?v=4) onnext/image, hostname "avatars2.githubusercontent.com" is not configured under images in yournext.config.js See more info: https://nextjs.org/docs/messages/next-image-unconfigured-host

should I add avatars2.githubusercontent.com to next.config.js or use the bare img element, this also shows a warning Usingcould result in slower LCP and higher bandwidth. Consider usingfromnext/imageto automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element but it works @pettinarip

pettinarip commented 1 month ago

Right @Baystef lets use the img tag for now. You can leave the warning.

yashtotla commented 1 month ago

Hi @pettinarip can you assign the ProductCard.tsx migration to me? Thanks!

kushagrasarathe commented 1 month ago

hey @pettinarip could you please assign ExpandableCard.tsx's migration to me. Thanks

pettinarip commented 1 month ago

@yashtotla @kushagrasarathe thanks for helping! assigned, thanks

kushagrasarathe commented 1 month ago

hey @pettinarip have made a pr for ExpandableCard.tsx, meanwhile can you assign me these remaining card components please:

Thanks 🙌

pettinarip commented 1 month ago

Assigned @kushagrasarathe and @saurabhburade!

Quick reminder: create a separate PR for each component please. Thank you guys!

ashiskumar-1999 commented 1 month ago

Hi @pettinarip , I can work on these files. Please assign me.

sahildotdev commented 1 month ago

Hi @pettinarip ,

I would like to work on these files , could you please assign me.

Baystef commented 1 month ago

@pettinarip please assign GitStars and History/NetworkUpgradeSummary.tsx to me. Thanks

pettinarip commented 1 month ago

I've updated the list @ashiskumar-1999 @sahildotdev @Baystef ✌🏼

0xgun commented 1 month ago

Hi @pettinarip can you assign the StablecoinsTable.tsx migration to me? Thanks

yashtotla commented 1 month ago

@pettinarip can you assign the ProductList.tsx migration to me?

pettinarip commented 1 month ago

@0xgun assigned! 💪🏼 For this one,lets use the shadcn table component.

pettinarip commented 1 month ago

@pettinarip can you assign the ProductList.tsx migration to me?

Done! thanks @yashtotla

saurabhburade commented 1 month ago

@pettinarip Please assign me DocLink &DocsNav.

pettinarip commented 1 month ago

FYI added more components to migrate from the /Staking and /Translatathon folders.

0xgun commented 1 month ago

@pettinarip please assignTranslatathon/ApplyNow.tsx LocalCommunitiesList and DatesAndTimeline components to me. Thanks

Sambit03 commented 1 month ago

hey @pettinarip like to work on those file. Can you please assign

pettinarip commented 1 month ago

Assigned @Sambit03. Thanks, let me know if you have any questions.

Sambit03 commented 1 month ago

Assigned @Sambit03. Thanks, let me know if you have any questions.

https://github.com/ethereum/ethereum-org-website/pull/14066

Baystef commented 1 month ago

@pettinarip please assign

to me

atharv-av commented 1 month ago

hey @pettinarip
please assign Trilemma/index.tsx component to me.

pettinarip commented 1 month ago

@Baystef I've assigned you the first 4 for now, just to give others a chance to join in the meantime. Once you are done with them, I can assign the rest if no one else has requested them.

Thanks!

pettinarip commented 1 month ago

Assigned @atharv-av!

husna3249 commented 1 month ago

Hey @pettinarip pls assign Staking/StakingGuides.tsx to me

pettinarip commented 1 month ago

Hey @pettinarip pls assign Staking/StakingGuides.tsx to me

Done! is yours, thanks for helping 🚀 Let us know if you need help.

atharv-av commented 1 month ago

hello @pettinarip please assign Layer2/Layer2Onboard.tsx to me

Baystef commented 1 month ago

@Baystef I've assigned you the first 4 for now, just to give others a chance to join in the meantime. Once you are done with them, I can assign the rest if no one else has requested them.

  • Roadmap/RoadmapImageContent
  • Staking/StakingHowSoloWorks
  • Staking/StakingProductsCardGrid/index.tsx
  • Staking/StakingStatsBox

Thanks!

PR up for the 4

pettinarip commented 1 month ago

Assigned @atharv-av!

pettinarip commented 1 month ago

@Baystef I've assigned you the first 4 for now, just to give others a chance to join in the meantime. Once you are done with them, I can assign the rest if no one else has requested them.

  • Roadmap/RoadmapImageContent
  • Staking/StakingHowSoloWorks
  • Staking/StakingProductsCardGrid/index.tsx
  • Staking/StakingStatsBox

Thanks!

PR up for the 4

Wow, that was fast, thanks @Baystef. I'll check those PRs soon.

In the meantime, I've assigned the other components you requested before.

atharv-av commented 1 month ago

Assigned @atharv-av!

Please check the PR.

yun-chiao commented 1 month ago

Hi @pettinarip, please assign SocialListItem.tsx to me, thanks.

pettinarip commented 1 month ago

Done @yun-chiao! thanks!

yun-chiao commented 1 month ago

Hi @pettinarip , please assign ActionCard.tsx to me, thanks!

Baystef commented 1 month ago

@Baystef I've assigned you the first 4 for now, just to give others a chance to join in the meantime. Once you are done with them, I can assign the rest if no one else has requested them.

  • Roadmap/RoadmapImageContent
  • Staking/StakingHowSoloWorks
  • Staking/StakingProductsCardGrid/index.tsx
  • Staking/StakingStatsBox

Thanks!

PR up for the 4

Wow, that was fast, thanks @Baystef. I'll check those PRs soon.

In the meantime, I've assigned the other components you requested before.

  • Staking/WithdrawalsTabComparison.tsx
  • Staking/StakingLaunchpadWidget.tsx
  • Staking/StakingCommunityCallout.tsx

@pettinarip, when OldText is removed and replaced with a normal p tag, the global styles of OldText gets lost obviously.

    margin-bottom: 1.45rem;
    line-height: 1.6rem;

So my question is should I add a global p tag style with the exact style OldText was using or add the tailwind style on individual p tags or should I leave it squashed as is and you guys will handle it globally?

ameeetgaikwad commented 1 month ago

@pettinarip

Would like to work on TranslationBannerLegal.tsx, TranslationBanner.tsx, TranslationLeaderboard.tsx

Please assign.

pettinarip commented 1 month ago

@pettinarip, when OldText is removed and replaced with a normal p tag, the global styles of OldText gets lost obviously.

    margin-bottom: 1.45rem;
    line-height: 1.6rem;

So my question is should I add a global p tag style with the exact style OldText was using or add the tailwind style on individual p tags or should I leave it squashed as is and you guys will handle it globally?

@Baystef to simplify the migration, we try to match production as much as possible. For now, we won't set a global style for the paragraph as we don't have much consistency in them. What I would suggest is that you try to control the spacing from the parent using gap. If not, you could set the margin on each paragraph.

Another thing I would like to see if possible is the usage one of the tw sizes/scale, instead of the custom 1.45rem, feel free to use mb-6 (1.5rem) or whatever works best in this case.

pettinarip commented 1 month ago

@pettinarip

Would like to work on TranslationBannerLegal.tsx, TranslationBanner.tsx, TranslationLeaderboard.tsx

Please assign.

Hi @ameeetgaikwad 👋🏼 happy to see you around!

I've assigned those to you. Ty

Baystef commented 1 month ago

Please assign these to me @pettinarip

pettinarip commented 4 weeks ago

@Baystef assigned. Will review those new PRs soon, thanks!

cqw-acq commented 4 weeks ago

@pettinarip hey! i want to work on "RollupProductDevDoc.tsx"

pettinarip commented 4 weeks ago

Its yours! @cqw-acq thanks. Let us know if you need help.

bhushanpardeshii commented 4 weeks ago

Hey @pettinarip can you assign me stat/index.tsx