search

ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.09k stars 4.83k forks source link

Add smart contract quiz fixes #13776 #13981

Closed JanetMo closed 1 month ago

JanetMo commented 1 month ago

Add a quiz about smart contracts (https://ethereum.org/en/smart-contracts/), by @Qwerky7835 and me. Related issue #13776.

Please review (-:

netlify[bot] commented 1 month ago

Deploy Preview for ethereumorg ready!

Name Link
Latest commit 78609fd7d4d0874c4ef355f5864fb2884bf45262
Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/670bd8f6f536fc000811f6b4
Deploy Preview https://deploy-preview-13981--ethereumorg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 7 paths audited
Performance: 50 (🔴 down 3 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Shiva-Sai-ssb commented 1 month ago

Hey @JanetMo, as you can see, the Netlify checks have failed due to errors in the build process.

To fix this, I suggest adding the smart-contracts site to the condition in this file: QuizzesStats.stories.tsx. This should resolve the issue with the build process.

Also, your branch has conflicts, try to resolve them and commit the latest changes.

JanetMo commented 1 month ago

Hi @Shiva-Sai-ssb, thanks for your comments and the suggestions! @Qwerky7835 fixed the issues and posted a new PR from her account here: https://github.com/ethereum/ethereum-org-website/pull/14162