ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.04k stars 4.78k forks source link

Suggest a Samsung Blockchain Wallet. #2886

Closed Jongkeun-Choi closed 3 years ago

Jongkeun-Choi commented 3 years ago

Before suggesting a wallet, make sure you've read our listing policy.

Only continue with the issue if your wallet meets the criteria listed there.

If it does complete the following information which we need to accurately list the wallet.

Is your wallet globally accessible?

-> Firstly, No KYC requirement. And there are geographic/device limitations of our wallet.

Is your wallet custodial, non-custodial, or a hardware wallet?

-> non-custodial

We allow users to get 12-word recovery phrase. Regardless of company/project's EOS, user can access their funds with the recovery phrase.

Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible

-> Your private key used to make transactions or payments in Samsung Blockchain Wallet is stored in a secure area of your device, accessible only by your PIN or recovery phrase. Screens that you enter recovery phrase, PIN, and fingerprint works on a secure OS isolated from Android OS, so they are safe from hacks from outside and data leakage.

Does the wallet have fiat on-ramps?

-> SBW don't subsidise any transaction fees.

Does the wallet allow users to explore dapps?

-> SBW allow users to browse and explore dapps. Also, Any collectibles user recieve are stored securely within the app. In our wallet, discover about 4-50 dapps, which are web-based and app-based integrated with our Samsung Blockchain SDKs.

For more informations : https://developer.samsung.com/blockchain

Does the wallet have integrated defi/financial tools?

-> We don't provide that tools directly.

However, our wallet is integrated with exchange(Gemini), so If user are using from one of the supported countries(USA, CANADA), the exchange link feature will be availabe. Coin/tokens can be purchased from an exchange and be transferred to Samsung Blockchain Wallet.

Can a user withdraw to their card?

-> No.

Does the wallet offer limits protection?

-> No.

Does the wallet allow high-volume purchases?

-> No.

Does the wallet have an integrated token swap?

-> No.

Is the wallet a multi-signature wallet?

-> No.

Wallet title

-> Samsung Blockchain Wallet

Wallet description

-> Keep your valuables safe and secure with Samsung Blockchain.

Wallet logo

-> Please find the attached.

wallet_app_ic_72x72 wallet_app_ic_144x144

Background colour for brand logo

-> Please white.

====================

Also, Please refer to below link : https://www.samsung.com/global/galaxy/apps/samsung-blockchain/

wackerow commented 3 years ago

@Jongkeun-Choi Thanks for submitting! We'll check it out and try to get back to you within a couple weeks

GeorgeTrotter commented 3 years ago

Hey @Jongkeun-Choi - in terms of security measures for this wallet, has the code been audited? Is your code open source? Is there a bug bounty or some equivalent? Let us know!

Jongkeun-Choi commented 3 years ago

Hi, George

It's not an open source. Plus, there isn't any bug bounty.

Firstly, Samsung Galaxy Mobile has a 'Samsung Knox'(security mobile platform), which store and mange some datas on Secure OS isolated with Android OS.

Also, There is a Samsung Blockchain Keystore(type of preloaded app on Samsung Galaxy Mobile)that has to use and work with this security mobile platform. By using this platform, Keystore allows private keys to be created, stored, and managed securely in secure area.

The point is that our wallet is integrated with this Keystore, and working on. If you wanna get more info, i want you to refer below link. you can check how wallet is working with Keystore.

Link : https://us.community.samsung.com/t5/Samsung-Apps-and-Services/OFFICIAL-Samsung-Blockchain-Keystore-amp-Wallet-Tutorial/td-p/1561814

Jongkeun-Choi commented 3 years ago

Hi, team. Could you share the status of progress?, If there's any problem to proceed, please tell us. :)

GeorgeTrotter commented 3 years ago

Hey @Jongkeun-Choi! We'll go ahead with adding this wallet. @wackerow will help with a PR!

Jongkeun-Choi commented 3 years ago

Thank you for your support!, Feel free to ask us if you guys have any inquiry to prepare a PR.

wackerow commented 3 years ago

@Jongkeun-Choi Thanks for bearing with us, just put up a PR to list SBW, will merge in momentarily

Jongkeun-Choi commented 3 years ago

Hi, @wackerow, Thank you for your help. And seems there's a issue while merging. could find 'Merging is blocked' in that merge. could you check it once?

wackerow commented 3 years ago

@Jongkeun-Choi Hey, following up on this, small bug needs patching on the PR before merging. It will be addressed and merged before the next site deployment.

Jongkeun-Choi commented 3 years ago

Thanks for sharing!