ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.03k stars 4.77k forks source link

Establishing a process to add more wallets #743

Closed p0s closed 4 years ago

p0s commented 4 years ago

Disclaimer & context: I'm working for imToken, the probably most used non-custodial Ethereum wallet in China and probably world-wide. We also helped translate ethereum.org into Chinese.

Is your feature request related to a problem? Please describe. From looking at recent related PRs like #683 #342 #316 I found that we stopped adding wallets to https://ethereum.org/wallets/ .

I can understand that you stopped adding wallets. Probably because processes are hard to do, maintain in a way to satisfy everybody. Right?

I guess you already know why wallets ask to be added. For completeness let me add anyways:

  1. First, listing on ethereum.org improves search ranking for listed wallets.
  2. Second, listing increases organic traffic to the wallet's site. That's why everybody wants to get in. It's literally worth $ to us. On the other hand, I guess that's also why it's a tough decision.

Describe the solution you'd like Establishing a process to add more wallets. I can offer help.

Now solutions I thought about

  1. Adding a nofollow tag will take away the advantage of improved page rank. But I don't like that, because why shouldn't EF endorse wallets. Not zero-sum. Listing helps Ethereum wallets to be higher than non-Ethereum and listing good wallets helps good wallet vs. bad wallets.
  2. Adding all wallets according to criteria adds more questions: Who sets and changes criteria? who deletes dead sites/wallets? who has time to add wallets?
  3. other solutions? Maybe link to only one comparison site; Make super sophisticated list of wallets. None of those that seem fair and/or good or possible to me right now.

If we chose 2), then how do we solve mentioned issues:

Who sets criteria? https://github.com/Swader/wallets-review seems pretty good start to find criteria and be able to copy them. I can help. Who changes criteria? Can be done via PR if people are unhappy. Who deletes dead links/wallets? Wallets will add PRs to delete dead links, because it is in their interest. I can help. Who has time to add wallets? Wallets will do it themselves.

Describe alternatives you've considered See above.

Additional context Maybe the same problem exists for other links to businesses on this site (dApps might be easy because some of them are pubic infrastructure). So a solution of this might help those as well.

samajammin commented 4 years ago

Thanks for the thoughtful issue @p0s. I agree this is worth discussing & establishing a process. We welcome additional input from the community on this.

Another consideration for this solution (in addition to the ones you listed) is user experience. There's plenty of research out there on the adverse effects of choice, so it's a delicate balance to provide users with options but not so many that overwhelm them or lead to analysis paralysis. We do have a RandomList component (which we use to shuffle the dapps we display) which may be an option to present an unbiased list. This, however, doesn't solve the core issue of curating a master list of wallets to display.

I think generally we do face similar issues for other resource sections of the site, so this could be a good way to set a precedent in terms of process. Inevitably there's some subjectivity in picking "winners" & "losers" of what is displayed on the site but to the best of our ability, I'd like to see ethereum.org maintain neutrality. Identifying quantitative metrics that answer considerations we outline in our README (Is it widely used? Is it well documented? Is it of sufficient quality?), whether those are self-reported in PRs or pulled from some 3rd party, might help remove the subjectivity of the process.

ghost commented 4 years ago

"Second, listing increases organic traffic to the wallet's site. That's why everybody wants to get in. It's literally worth $ to us. On the other hand, I guess that's also why it's a tough decision."

I think this is a very good point. Why doesnt the EF create a voting system similar to that of https://dap.ps/

It would be an avenue for EF to obtain more funding, as well as give a fair method to curate the wallet listing. Since its EF's site, submissions are subject to auditing (can be paid for by votes) for approval to prevent malicious wallets and let users vote on which wallets get listed first.

akatsuAK commented 4 years ago

Thanks for the thoughtful issue @p0s. I agree this is worth discussing & establishing a process. We welcome additional input from the community on this.

Another consideration for this solution (in addition to the ones you listed) is user experience. There's plenty of research out there on the adverse effects of choice, so it's a delicate balance to provide users with options but not so many that overwhelm them or lead to analysis paralysis. We do have a RandomList component (which we use to shuffle the dapps we display) which may be an option to present an unbiased list. This, however, doesn't solve the core issue of curating a master list of wallets to display.

I think generally we do face similar issues for other resource sections of the site, so this could be a good way to set a precedent in terms of process. Inevitably there's some subjectivity in picking "winners" & "losers" of what is displayed on the site but to the best of our ability, I'd like to see ethereum.org maintain neutrality. Identifying quantitative metrics that answer considerations we outline in our README (Is it widely used? Is it well documented? Is it of sufficient quality?), whether those are self-reported in PRs or pulled from some 3rd party, might help remove the subjectivity of the process.

Is there any updates to the this? I also want to see status listed under the wallets section. Its amazing how argent got listed, while Status, which is much a older project, and is the only developing team trying to improve the whisper protocol has been given the short end of the stick.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

samajammin commented 4 years ago

Reopening

dannyexodus commented 4 years ago

Hi all, I was directed to this issue from #1110

Perhaps for curating wallets while not overloading the user with choices, EF could look at App Store/Play Store reviews? Or some other neutral indicator that shows that the wallet in question is popular and liked by users?

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

ryancreatescopy commented 4 years ago

We've worked on a clearer framework for this process, we welcome your thoughts.:

This is a draft of a policy for ethereum.org about how we decide what wallets or dapps should be listed on the website. For instance, this policy would be used for:

This policy will be published in the github readme for ethereum.org, and be open for public comment. We'll expect anyone submitting a PR that adds a wallet or dapp to review this beforehand, and we'll refer to it when we have to reject a PR and explain why we did so.

Draft:

Anyone is free to suggest new wallets and dapps to the content on ethereum.org, where it's appropriate to do so. No, we won't list your dapp on our homepage 😜

We currently list wallets and dapps on:

Please only suggest new additions on these pages.

Although we welcome new additions, we chose the current wallets and dapps based on an experience we're trying to create for our users. These are based on some of our design principles:

Overall we want to provide a "seamless onboarding experience" for new users. So for that reason, we add wallets/dapps based on their:

Here's our decision framework in more detail. Please feel free to provide feedback or suggest changes.

How we decide

Criteria for inclusion: the must-haves

Criteria for ranking: the nice-to-haves

If we add your dapp or wallet it may not be listed as prominently as others. This is because we also consider the following criteria when designing our pages.

Wallets


Dapps


Both


Criteria in practice

The more of the criteria you fill, the more likely we'll list your product.

A product we list that only meets the must-haves may be removed if a new product is suggested that meets the must-haves and several of the nice-to-haves.

Other things that will factor into this decision:

This is a design decision that we alone are responsible for.

But rest assured, even if we don't list your product, we'll provide prominent links to other websites in the ecosystem that rank all dapps/wallets for users that want to see more choices.

Maintenance

As is the fluid nature of Ethereum, teams and products come and go and innovation happens daily, so we'll undertake routine checks of our content to:

You can help with this by checking and letting us know if we should update.

We're also investigating options for voting so the community can indicate their preferences and highlight the best products out there for us to recommend.

p0s commented 4 years ago

looks good to me! appreciate the thought you put into it!