search

ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.09k stars 4.83k forks source link

Bug report: Inaccurate information about StaFi staking pool #9740

Closed Tore19 closed 1 year ago

Tore19 commented 1 year ago

Describe the bug

Hi, I'm from StaFi. We believe there is some information about StaFi from this page(https://ethereum.org/en/staking/pools) that needs to be updated.

image

Any validator can run nodes through StaFi, so it should be permissionless.

Please check the rETH APP: https://app.stafi.io/validator/reth/choose-validator

image

To reproduce

  1. Go to 'https://ethereum.org/en/staking/pools'
  2. Scroll down to 'Explore staking pools'
  3. See error

Expected behavior

It should be permissionless about StaFi staking pool.

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

vishal590 commented 1 year ago

hi @corwintines, assign this issue to me. I can work on this issue.

wackerow commented 1 year ago

@Tore19 Thanks for posting this... I'll be dedicating time over the next two weeks to get through reviewing PRs related to staking products and will include this.

@vishal590 Appreciate the offer here. I'm going to self assign this though for review of the request being made... if you'd like to look into any of this yourself in the meantime and post your findings in support of or refuting anything mentioned, happy to take a look at anything you find. 🙏

vishal590 commented 1 year ago

@wackerow ok

Tore19 commented 1 year ago

@wackerow Great! Thanks!

wackerow commented 1 year ago

@Tore19 Just took a look at this, and overall sounds good! Great to see more options for permissionless node operation.

One question / some feedback...

image

This confused me at first when I saw "SOLO", which I implied I would need to stake alone, vs only contributing 12 ETH and filling in the rest with pooled stakers.

That doesn't necessarily prevent this PR from moving forward, but wanted to offer that bit of feedback. I'll toss up a PR to update this flag.

Tore19 commented 1 year ago

@wackerow Hi, in StaFi APP, "SOLO Validator" means contributing 12 ETH and filling in the rest with pooled stakers, vs "Trusted Validator" means self-deposited 0 ETH.

But yeah, I understand what you mean, there is indeed a little confusion. We will try to make users understand what we want to express.

Really thanks for your feedback!