ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony
GNU Lesser General Public License v3.0
2.18k stars 1.1k forks source link

Move crypto package out of core #1130

Open mkalinin opened 6 years ago

mkalinin commented 6 years ago

It would be pretty useful for developers to have crypto package separated from core and maintained as an independent module with its own artifact.

RichardH92 commented 6 years ago

@mkalinin Would this involve making a separate gradle poject for just crypto but leaving in the same repo?

mkalinin commented 6 years ago

Yep. crypto should be a separate module with its own dependencies and tests like ethereumj-core and having its own publishing process. Then it will make sense to have core module dependent on crypto. It also make sense if crypto module will have a facade describing its main entry points, so, it will be possible to implement custom module which will serve as a crypto features provider.